用于打印字母的java For循环

Question

public class LetterPrint {
    int totalLines;
    int consecLines;
    int timesPrintedinLine;
    int linesPrinted;
    char currentChar;
    LetterPrint(int totalLines, int consecLines){
        this.totalLines = totalLines;
        this.consecLines = consecLines;
    }
    void beginPrinting(){
        for(timesPrintedinLine = 0; linesPrinted<=totalLines; timesPrintedinLine++)
        {
            Print();
        }
    }
    public char correctChar(){
        if(timesPrintedinLine/(consecLines*4) == 1)
            return currentChar = 'A';
        else 
            return currentChar = 'B';

    }
    void Print(){
        if (timesPrintedinLine%5 !=0)
            System.out.print(correctChar());
        else{
            System.out.println();
            linesPrinted = timesPrintedinLine/4;
        }

    }
}

有人能帮我看看为什么用“LetterPrint letterPrinter=new LetterPrint（6,1）；”创建时这个物体正在打印

BBBA
AABB
BBBB
BBBB
BBBB
BBBB 

而不是

AAAA
BBBB
AAAA
BBBB
AAAA
BBBB

我感谢任何能帮我澄清此事的人

Answer 1

既然原始代码不是“最好的”，我就重写了它：

public class LetterPrint
{
    private final static int charsInLine = 4;

    private final int totalLines;
    private final int consecLines;

    public LetterPrint(int totalLines, int consecLines)
    {
        this.totalLines = totalLines;
        this.consecLines = consecLines;
    }

    public void beginPrinting()
    {
        for (int lineNumber = 0; lineNumber < totalLines; lineNumber++)
        {
            char currentChar = getChar(lineNumber);
            for (int charNumber = 0; charNumber < charsInLine; charNumber++)
            {
                System.out.print(currentChar);
            }
            System.out.println();
        }
    }

    private char getChar(int lineNumber)
    {
        if ((lineNumber / consecLines) % 2 == 0)
        {
            return 'A';
        }
        return 'B';
    }
}

Answer 2

尽可能地更正了代码

public class LetterPrint {
    int totalLines;
    int consecLines;
    int timesPrintedinLine;
    int linesPrinted;
    char currentChar;
    LetterPrint(int totalLines, int consecLines){
        this.totalLines = totalLines;
        this.consecLines = consecLines;
    }
    void beginPrinting(){
        for(timesPrintedinLine = 1; linesPrinted<=totalLines; timesPrintedinLine++)
        {
            Print();
        }
    }
    public char correctChar(){
        if((timesPrintedinLine/(consecLines*4+1)) %2  == 0)
            return currentChar = 'A';
        else 
            return currentChar = 'B';

    }
    void Print(){
        if (timesPrintedinLine%5 !=0)
            System.out.print(correctChar());
        else{
            System.out.println();
            linesPrinted = timesPrintedinLine/4;
        }

    }

    public static void main(String ar[])
    {
     LetterPrint LETTERPRINTER = new LetterPrint(6,1);
     LETTERPRINTER.beginPrinting();
    }
}

产量与预期一致

AAAA
BBBB
AAAA
BBBB
AAAA
BBBB

所做的改变是

1. for循环从1开始，以避免打印第一个空行
2. 函数correctChar中的条件已更改，以适应后续的更改。（您的仅限于第一次迭代）

如果你想要解释，请询问

Answer 3

逐步完成每个过程timesPrintedInLine是第一个0，所以在Print()中它将打印一行新行。当timesPrintedInLine为1时，1不是5的倍数，因此System.out.print将在Print()中打印从correctChar()返回的char；因为1/（1*4）不等于1，所以打印B。同样的情况也发生在2和3上

当timesPrintedInLine为4时，我们再次转到correctChar()A这次打印

timesPrintedInLine现在变为5，所以打印一个新行，linesPrinted现在等于5/4，或1

对于timesPrintedInLine=6和7，打印A，因为6/4和7/4等于1

从这一点开始，timesPrintedInLine将始终大于7。随后，timesPrintedInLine/（1*4）永远不能等于1，这就是为什么总是打印B（除非timesPrintedInLine是5的倍数；在这种情况下，打印一个新行，并且linesPrinted等于timesPrintedInLine/4）

问题来自if语句，因此将其更改为：

if(timesPrintedinLine/(consecLines*5) % 2 == 0)

Answer 4

首先，TimesPrintedLine和LineSprint的约定和最佳实践需要声明为局部变量。 第二，不要经常给系统打电话。出去

现在正确的代码可以是：

public class LetterPrint {
   private static final int CHARS_BY_CONSLINES = 4; 

   private int totalLines;
   private int consecLines;

   LetterPrint(int totalLines, int consecLines){
       this.totalLines = totalLines;
       this.consecLines = consecLines;
   }

   void beginPrinting(){
       String text;
       for(int rows = 0; rows < totalLines; rows++){
           text = "";
           for (int cols = 0; cols < consecLines*CHARS_BY_CONSLINES; cols++) {
               text += printChar(rows);
           }
           System.out.println(text);
       }
   } 

   void printChar(int row){
       if (row%2==0)
           return "A";
       else
           return "B"
   }

}