在我的新工作中,我一直在自学Python,并且非常喜欢这种语言。我写了一个简短的类来做一些基本的数据操作,我对此很有信心。在
但我在结构化/模块化编程时代的旧习惯很难改掉,我知道一定有更好的方法来写这个。所以,我想知道是否有人愿意看看下面的内容,并提出一些可能的改进建议,或者让我找到一个资源,可以帮助我自己发现这些。在
简要说明:RandomItems根类是由其他人编写的,我仍在研究itertools库。而且,这并不是整个模块-只是我正在处理的类,这是先决条件。在
你觉得怎么样?在
import itertools
import urllib2
import random
import string
class RandomItems(object):
"""This is the root class for the randomizer subclasses. These
are used to generate arbitrary content for each of the fields
in a csv file data row. The purpose is to automatically generate
content that can be used as functional testing fixture data.
"""
def __iter__(self):
while True:
yield self.next()
def slice(self, times):
return itertools.islice(self, times)
class RandomWords(RandomItems):
"""Obtain a list of random real words from the internet, place them
in an iterable list object, and provide a method for retrieving
a subset of length 1-n, of random words from the root list.
"""
def __init__(self):
urls = [
"http://dictionary-thesaurus.com/wordlists/Nouns%285,449%29.txt",
"http://dictionary-thesaurus.com/wordlists/Verbs%284,874%29.txt",
"http://dictionary-thesaurus.com/wordlists/Adjectives%2850%29.txt",
"http://dictionary-thesaurus.com/wordlists/Adjectives%28929%29.txt",
"http://dictionary-thesaurus.com/wordlists/DescriptiveActionWords%2835%29.txt",
"http://dictionary-thesaurus.com/wordlists/WordsThatDescribe%2886%29.txt",
"http://dictionary-thesaurus.com/wordlists/DescriptiveWords%2886%29.txt",
"http://dictionary-thesaurus.com/wordlists/WordsFunToUse%28100%29.txt",
"http://dictionary-thesaurus.com/wordlists/Materials%2847%29.txt",
"http://dictionary-thesaurus.com/wordlists/NewsSubjects%28197%29.txt",
"http://dictionary-thesaurus.com/wordlists/Skills%28341%29.txt",
"http://dictionary-thesaurus.com/wordlists/TechnicalManualWords%281495%29.txt",
"http://dictionary-thesaurus.com/wordlists/GRE_WordList%281264%29.txt"
]
self._words = []
for url in urls:
urlresp = urllib2.urlopen(urllib2.Request(url))
self._words.extend([word for word in urlresp.read().split("\r\n")])
self._words = list(set(self._words)) # Removes duplicates
self._words.sort() # sorts the list
def next(self):
"""Return a single random word from the list
"""
return random.choice(self._words)
def get(self):
"""Return the entire list, if needed.
"""
return self._words
def wordcount(self):
"""Return the total number of words in the list
"""
return len(self._words)
def sublist(self,size=3):
"""Return a random segment of _size_ length. The default is 3 words.
"""
segment = []
for i in range(size):
segment.append(self.next())
#printable = " ".join(segment)
return segment
def random_name(self):
"""Return a string-formatted list of 3 random words.
"""
words = self.sublist()
return "%s %s %s" % (words[0], words[1], words[2])
def main():
"""Just to see it work...
"""
wl = RandomWords()
print wl.wordcount()
print wl.next()
print wl.sublist()
print 'Three Word Name = %s' % wl.random_name()
#print wl.get()
if __name__ == "__main__":
main()
这是我的五分钱:
__init__
。在random.sample
来废除一些代码,它做你的next()
和{__iter__
(在类中定义方法),这样就可以去掉RandomIter
。您可以在docs中阅读更多关于它的信息(注意Py3K,有些内容可能与较低版本无关)。您可以使用yield
来创建一个生成器,从而几乎不浪费内存。在random_name
可以改为使用^{[str(x) for x in iterable]
或内置map
来完成。在第一个下意识的反应:我会将硬编码的url卸载到传递给类的构造函数参数中,或者从某个地方的配置中读取;这将允许更容易的更改,而无需重新部署。在
这样做的缺点是类的使用者必须知道这些URL存储在哪里。。。因此,您可以创建一个同伴类,其唯一的工作就是知道url是什么(即在配置中,甚至是硬编码的)以及如何获取它们。您可以允许类的使用者提供URL,或者,如果没有提供URL,类可以打开URL的伴生类。在
相关问题 更多 >
编程相关推荐