Django:保存后信号事务管理

2024-04-25 23:15:05 发布

您现在位置:Python中文网/ 问答频道 /正文

我使用post-save signal作为模型来启动芹菜任务。它以前工作过,但突然,它给了我一个事务管理错误。你知道吗

型号

class FieldSightXF(models.Model):
    xf = models.ForeignKey(XForm, related_name="field_sight_form")
    site = models.ForeignKey(Site, related_name="site_forms", null=True, blank=True)
    project = models.ForeignKey(Project, related_name="project_forms", null=True, blank=True)
    is_staged = models.BooleanField(default=False)
    is_scheduled = models.BooleanField(default=False)
    date_created = models.DateTimeField(auto_now=True)
    date_modified = models.DateTimeField(auto_now=True)
    schedule = models.OneToOneField(Schedule, blank=True, null=True, related_name="schedule_forms")
    stage = models.OneToOneField(Stage, blank=True, null=True, related_name="stage_forms")
    shared_level = models.IntegerField(default=2, choices=SHARED_LEVEL)
    form_status = models.IntegerField(default=0, choices=FORM_STATUS)
    fsform = models.ForeignKey('self', blank=True, null=True, related_name="parent")
    is_deployed = models.BooleanField(default=False)
    is_deleted = models.BooleanField(default=False)
    is_survey = models.BooleanField(default=False)
    from_project = models.BooleanField(default=True)
    default_submission_status = models.IntegerField(default=0, choices=FORM_STATUS)
    logs = GenericRelation('eventlog.FieldSightLog')

    class Meta:
        db_table = 'fieldsight_forms_data'
        # unique_together = (("xf", "site"), ("xf", "is_staged", "stage"),("xf", "is_scheduled", "schedule"))
        verbose_name = _("XForm")
        verbose_name_plural = _("XForms")
        ordering = ("-date_created",)

保存后信号

@receiver(post_save, sender=FieldSightXF)
def share_form(sender, instance, created,  **kwargs):
    if instance.project is not None and created:
        from onadata.apps.fsforms.tasks import share_form_managers
        task_obj = CeleryTaskProgress.objects.create(user=instance.xf.user,
                                                     description="Share Forms",
                                                     task_type=17, content_object=instance)
        if task_obj:
            try:
                share_form_managers.delay(instance.id, task_obj.id)
            except:
                pass

post_save.connect(create_messages, sender=FieldSightXF)

CeleryTaskProgress用于跟踪芹菜任务的进度。你知道吗

任务

@shared_task(max_retires=5)
def share_form_managers(fxf, task_id):
    fxf = FieldSightXF.objects.get(pk=fxf)
    userrole = UserRole.objects.filter(project=fxf.project, group__name='Project Manager')
    users = User.objects.filter(user_roles__in=userrole)
    shared = share_form(users, fxf.xf)
    if shared:
        CeleryTaskProgress.objects.filter(id=task_id).update(status=2)
    else:
        CeleryTaskProgress.objects.filter(id=task_id).update(status=3)

共享表单方法

def share_form(users, xform):
    from onadata.apps.fsforms.models import ObjectPermission, Asset
    for user in users:
        try:
            codenames = ['view_asset', 'change_asset']
            permissions = Permission.objects.filter(content_type__app_label='kpi', codename__in=codenames)
            for perm in permissions:
                object_id = Asset.objects.get(uid=xform.id_string).id
                content_type = ContentType.objects.get(id=21)

                # Create the new permission
                new_permission = ObjectPermission.objects.create(
                    object_id=object_id,
                    content_type=content_type,
                    user=user,
                    permission_id=perm.pk,
                    deny=False,
                    inherited=False
                )

        except:
            return False
        else:
            return True

这个过程所做的是,每当创建FieldSightXF的对象(表单被分配给项目)时,表单就被共享给该项目的项目经理。你知道吗

以前我将FieldSightXF对象作为参数传递给任务时没有问题,但现在我将对象id作为:

以前

share_form_managers.delay(instance, task_obj.id)

电流

share_form_managers.delay(instance.id, task_obj.id) 

现在,这两个案例都给了我提到的错误。如果我从post save signal方法中对上述行进行注释,则错误消失。

我确实试过从其他答案中得到的建议,但它们对我不起作用。你知道吗

完全错误回溯:

ERROR 2019-06-13 10:49:50,743 base 11527 140653367232256 Internal Server Error: /forms/api/fxf/
Traceback (most recent call last):
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/viewsets.py", line 87, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/views.py", line 466, in dispatch
    response = self.handle_exception(exc)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/views.py", line 463, in dispatch
    response = handler(request, *args, **kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/mixins.py", line 21, in create
    self.perform_create(serializer)
  File "/home/sanip/naxa/source/fieldsight/onadata/apps/fsforms/viewsets/FieldSightXformViewset.py", line 85, in perform_create
    fxf.save()
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 734, in save
    force_update=force_update, update_fields=update_fields)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 762, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 827, in _save_table
    forced_update)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 877, in _do_update
    return filtered._update(values) > 0
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/query.py", line 580, in _update
    return query.get_compiler(self.db).execute_sql(CURSOR)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1062, in execute_sql
    cursor = super(SQLUpdateCompiler, self).execute_sql(result_type)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 840, in execute_sql
    cursor.execute(sql, params)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/backends/utils.py", line 79, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/backends/utils.py", line 59, in execute
    self.db.validate_no_broken_transaction()
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/backends/base/base.py", line 327, in validate_no_broken_transaction
    "An error occurred in the current transaction. You can't "
TransactionManagementError: An error occurred in the current transaction. You can't execute queries until the end of the 'atomic' block.
Internal Server Error: /forms/api/fxf/
Traceback (most recent call last):
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/viewsets.py", line 87, in view
    return self.dispatch(request, *args, **kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/views.py", line 466, in dispatch
    response = self.handle_exception(exc)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/views.py", line 463, in dispatch
    response = handler(request, *args, **kwargs)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/rest_framework/mixins.py", line 21, in create
    self.perform_create(serializer)
  File "/home/sanip/naxa/source/fieldsight/onadata/apps/fsforms/viewsets/FieldSightXformViewset.py", line 85, in perform_create
    fxf.save()
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 734, in save
    force_update=force_update, update_fields=update_fields)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 762, in save_base
    updated = self._save_table(raw, cls, force_insert, force_update, using, update_fields)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 827, in _save_table
    forced_update)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/base.py", line 877, in _do_update
    return filtered._update(values) > 0
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/query.py", line 580, in _update
    return query.get_compiler(self.db).execute_sql(CURSOR)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 1062, in execute_sql
    cursor = super(SQLUpdateCompiler, self).execute_sql(result_type)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/models/sql/compiler.py", line 840, in execute_sql
    cursor.execute(sql, params)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/backends/utils.py", line 79, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/backends/utils.py", line 59, in execute
    self.db.validate_no_broken_transaction()
  File "/home/sanip/.virtualenvs/kobocat/lib/python2.7/site-packages/django/db/backends/base/base.py", line 327, in validate_no_broken_transaction
    "An error occurred in the current transaction. You can't "
TransactionManagementError: An error occurred in the current transaction. You can't execute queries until the end of the 'atomic' block.

根据回溯,以下代码指出了错误:

def perform_create(self, serializer):
    is_survey = self.request.data.get('is_survey', False)
    fxf = serializer.save(is_survey=is_survey, is_deployed=True)
    if not fxf.project:
        fxf.from_project = False
    fxf.save() #<<--here
    if fxf.project:
        if not fxf.is_survey:    
            org = fxf.project.organization
            fxf.logs.create(source=self.request.user, type=18, title="General",
                      organization=org,
                      project = fxf.project,
                      content_object=fxf,
                      extra_object=fxf.project,
                      description='{0} assigned new General form  {1} to {2} '.format(
                          self.request.user.get_full_name(),
                          fxf.xf.title,
                          fxf.project.name))
    else:
        org = fxf.site.project.organization

        fxf.logs.create(source=self.request.user, type=19, title="General",
                                          organization=org,
                                          project=fxf.site.project,
                                          site = fxf.site,
                                          content_object=fxf,
                                          extra_object=fxf.site,
                                          description='{0} assigned new General form  {1} to {2} '.format(
                                              self.request.user.get_full_name(),
                                              fxf.xf.title,
                                              fxf.site.name
                                          ))

perform_create是viewset中的一个方法,当窗体被分配给项目时使用它。你知道吗


Tags: djangoinpyhomedbmodelslibpackages
1条回答
网友
1楼 · 发布于 2024-04-25 23:15:05

从错误中可以看出,您在数据库级别或视图级别启用了原子事务。你知道吗

在阅读了你的代码之后,我觉得问题是这样的。你知道吗

  • 您从perform\u create视图创建了一个新的FieldSightXF对象,但是由于启用了原子事务,该对象实际上并不存储在数据库中,而是在执行整段代码并将响应返回给用户时存储。

  • 现在当你打电话给fxf.保存(),处理后保存信号,调用函数共享形式。你知道吗

    @receiver(post_save, sender=FieldSightXF)
    def share_form(sender, instance, created,  **kwargs):
        if instance.project is not None and created:
            from onadata.apps.fsforms.tasks import share_form_managers
            task_obj = CeleryTaskProgress.objects.create(user=instance.xf.user,
                                                 description="Share Forms",
                                                 task_type=17, content_object=instance)
            if task_obj:
                try:
                    share_form_managers.delay(instance.id, task_obj.id)
                except:
                    pass
    
    post_save.connect(create_messages, sender=FieldSightXF)
    
  • 在share\u form function中,您使用FieldSightXF对象的id调用了任务共享表单管理器。

  • 现在,当芹菜执行您的任务时,点击数据库查找id=fxf的FieldSightXF对象和id=task\u id的芹菜任务进度对象时,它找不到它,因为它还不在数据库中,引发了一个DB错误。你知道吗

    @shared_task(max_retires=5)
    def share_form_managers(fxf, task_id):
        fxf = FieldSightXF.objects.get(pk=fxf) #<< here
        userrole = UserRole.objects.filter(project=fxf.project, group__name='Project Manager')
        users = User.objects.filter(user_roles__in=userrole)
        shared = share_form(users, fxf.xf)
        if shared:
            CeleryTaskProgress.objects.filter(id=task_id).update(status=2)
        else:
            CeleryTaskProgress.objects.filter(id=task_id).update(status=3)
    
  • 如果事务块中发生数据库错误,django将阻止任何进一步的数据库查询来停止损坏的数据的读/写。

  • 在perform\u create函数中,您试图在fxf.保存(),因此django正在引发事务错误。你知道吗

    def perform_create(self, serializer):
        is_survey = self.request.data.get('is_survey', False)
        fxf = serializer.save(is_survey=is_survey, is_deployed=True)
        if not fxf.project:
            fxf.from_project = False
        fxf.save() #<< here
        if fxf.project:
            if not fxf.is_survey:    
                org = fxf.project.organization
                fxf.logs.create(source=self.request.user, type=18, title="General",
                  organization=org,
                  project = fxf.project,
                  content_object=fxf,
                  extra_object=fxf.project,
                  description='{0} assigned new General form  {1} to {2} '.format(
                      self.request.user.get_full_name(),
                      fxf.xf.title,
                      fxf.project.name))
        else:
            org = fxf.site.project.organization
    
            fxf.logs.create(source=self.request.user, type=19, title="General",
                                      organization=org,
                                      project=fxf.site.project,
                                      site = fxf.site,
                                      content_object=fxf,
                                      extra_object=fxf.site,
                                      description='{0} assigned new General form  {1} to {2} '.format(
                                          self.request.user.get_full_name(),
                                          fxf.xf.title,
                                          fxf.site.name
                                      ))
    

我建议不要使用post\u save信号,而是从perform\u create视图调用share\u form\u managers任务,如下所示:

    from django.db import transaction

    def perform_create(self, serializer):
        is_survey = self.request.data.get('is_survey', False)
        fxf = serializer.save(is_survey=is_survey, is_deployed=True)
        if not fxf.project:
            fxf.from_project = False
        fxf.save()
        if fxf.project:
            # calling the task
            from onadata.apps.fsforms.tasks import share_form_managers
            task_obj = CeleryTaskProgress.objects.create(user=fxf.xf.user, description="Share Forms", task_type=17, content_object=instance)
            if task_obj:
                try:
                    transaction.on_commit(lambda: share_form_managers.delay(instance.id, task_obj.id))
                except:
                    pass
            # call block end
            if not fxf.is_survey:    
                org = fxf.project.organization
                fxf.logs.create(source=self.request.user, type=18, title="General", organization=org, project = fxf.project, content_object=fxf,extra_object=fxf.project, description='{0} assigned new General form  {1} to {2} '.format(self.request.user.get_full_name(),fxf.xf.title,fxf.project.name))
        else:
            org = fxf.site.project.organization

            fxf.logs.create(source=self.request.user, type=19, title="General", organization=org, project=fxf.site.project, site = fxf.site, content_object=fxf, extra_object=fxf.site, description='{0} assigned new General form  {1} to {2} '.format(self.request.user.get_full_name(),fxf.xf.title,fxf.site.name ))
  • 那个事务。在提交时将确保只有在perform\u create视图中的数据存储在数据库中之后才调用任务。你知道吗

如果有用请告诉我。你知道吗

以下是django的交易管理: https://docs.djangoproject.com/en/2.2/topics/db/transactions/

相关问题 更多 >