为什么Clojure在Euler 50的等价解中比Python慢10倍?
我最近开始学习Clojure,并决定通过解决欧拉问题来练习,目的是熟悉可用的数据结构,同时练习递归和循环。
我尝试了多种方法来解决问题50,但无论我怎么做,找出1000000的解答总是没能完成。在查看了其他人的做法后,我猜我做的也不应该花这么久,所以我在Python中输入了相应的算法,想看看问题是不是出在我对Clojure某些东西的理解不足,或者是Java的设置问题。结果Python在10秒内完成了。而对于100000以下的质数,Python版本只用了0.5秒,而Clojure则用了5秒。
我发布了这个专门为了与Python代码相匹配而创建的Clojure版本。你能帮我理解为什么性能差异这么大吗?我应该使用unchecked-add、类型提示、原始类型(但该用在哪里呢?)还是其他什么方法?
这是Clojure代码:
(defn prime? [n]
(let [r (int (Math/sqrt n))]
(loop [d 2]
(cond
(= n 1) false
(> d r) true
(zero? (rem n d)) false
:other (recur (inc d))))))
(defn primes []
(filter prime? (iterate inc 2)))
(defn cumulative-sum [s]
(reduce
(fn [v, x] (conj v (+ (last v) x)))
[(first s)]
(rest s)))
(defn longest-seq-under [n]
"Longest prime seq with sum under n"
(let [ps (vec (take-while #(< % n) (primes))) ; prime numbers up to n
prime-set (set ps) ; set for testing of inclusion
cs (cumulative-sum ps)
cnt (count ps)
max-len (count (take-while #(< % n) cs)) ; cannot have longer sequences
sub-sum (fn [i j] ; sum of primes between the i-th and j-th
(- (cs j) (get cs (dec i) 0)))
seq-with-len (fn [m] ; try m length prime sequences and return the first where the sum is prime
(loop [i 0] ; try with the lowest sum
(if (> i (- cnt m)) ; there are no more elements for and m length sequence
nil ; could not find any
(let [j (+ i (dec m)) ; fix length
s (sub-sum i j)]
(if (>= s n) ; overshoot
nil
(if (prime-set s) ; sum is prime
[i (inc j)] ; we just looked for the first
(recur (inc i))))))))] ; shift window
(loop [m max-len] ; try with the longest sequence
(if (not (zero? m))
(let [[i j] (seq-with-len m) ]
(if j
(subvec ps i j)
(recur (dec m))))))))
(assert (= [2 3 5 7 11 13] (longest-seq-under 100)))
(let [s1000 (longest-seq-under 1000)]
(assert (= 21 (count s1000)))
(assert (= 953 (reduce + s1000))))
; (time (reduce + (longest-seq-under 100000))) ; "Elapsed time: 5707.784369 msecs"
这是相应的Python代码:
from math import sqrt
from itertools import takewhile
def is_prime(n) :
for i in xrange(2, int(sqrt(n))+1) :
if n % i == 0 :
return False
return True
def next_prime(n):
while not is_prime(n) :
n += 1
return n
def primes() :
i = 1
while True :
i = next_prime(i+1)
yield i
def cumulative_sum(s):
cs = []
css = 0
for si in s :
css += si
cs.append( css )
return cs
def longest_seq_under(n) :
ps = list(takewhile( lambda p : p < n, primes()))
pss = set(ps)
cs = cumulative_sum(ps)
cnt = len(ps)
max_len = len(list(takewhile(lambda s : s < n, cs)))
def subsum(i, j):
return cs[j] - (cs[i-1] if i > 0 else 0)
def interval_with_length(m) :
for i in xrange(0, cnt-m+1) :
j = i + m - 1
sij = subsum(i,j)
if sij >= n :
return None, None
if sij in pss : # prime
return i, j+1
return None, None
for m in xrange(max_len, 0, -1) :
f, t = interval_with_length(m)
if t :
return ps[f:t]
assert longest_seq_under(100) == [2, 3, 5, 7, 11, 13]
assert sum(longest_seq_under(1000)) == 953
# import timeit
# timeit.Timer("sum(longest_seq_under(100000))", "from __main__ import longest_seq_under").timeit(1) # 0.51235757617223499
谢谢
2 个回答
15
我觉得慢的原因是你在longest-seq-under
里反复遍历序列的次数太多,每次遍历都会消耗时间。这里有一个非常快的版本,是结合了你的代码和这里的答案。注意,primes
是懒加载的,所以我们可以用def
来定义它,而不是用defn
:
(defn prime? [n]
(let [r (int (Math/sqrt n))]
(loop [d 2]
(cond (= n 1) false
(> d r) true
(zero? (rem n d)) false
:else (recur (inc d))))))
(def primes (filter prime? (iterate inc 2)))
(defn make-seq-accumulator
[[x & xs]]
(map first (iterate
(fn [[sum [s & more]]]
[(+ sum s) more])
[x xs])))
(def prime-sums
(conj (make-seq-accumulator primes) 0))
(defn euler-50 [goal]
(loop [c 1]
(let [bots (reverse (take c prime-sums))
tops (take c (reverse (take-while #(> goal (- % (last bots)))
(rest prime-sums))))]
(or (some #(when (prime? %) %)
(map - tops bots))
(recur (inc c))))))
在我的机器上,这个代码大约在6毫秒内完成:
user> (time (euler-50 1000000))
"Elapsed time: 6.29 msecs"
997651
4
我自己给自己的评论当答案,解释一下为什么Python能工作而Clojure却不行:在Clojure中,使用一个向量的last
操作是线性的,这导致我想要的累加和计算不成功。
我把函数更新为使用一个瞬态向量,像这样:
(defn cumulative-sum-2 [s]
(loop [[x & xs] s
ss 0
acc (transient [])]
(if x
(let [ssx (+ ss x)]
(recur xs ssx (conj! acc ssx)))
(persistent! acc))))
结果是Clojure的版本运行时间大约是Python的两倍,而且这个结果一直都是这样。我本来希望Clojure在做相同操作时能比Python快,不知道我是不是还漏掉了什么。顺便提一下,我用的是1.2版本。
谢谢