Django UpdateView未更新
我创建了一个Django应用,用户可以在里面记录他们的股票交易,算是一种日记
工具。当用户从首页点击某个具体的日记条目时,他们会被带到一个详细页面,展示该条目的所有信息(single_entry.html)。这个页面是通过UpdateView
来处理的。在这个页面上,用户可以编辑或更新任何信息,还可以删除这个特定的条目。表单上有两个按钮,一个是“删除”,另一个是“更新”。
删除功能运行得很好。更新功能以前是可以用的,但现在不知道为什么不行了!条目的信息没有任何更新。而且我也搞不清楚为什么“消息”中间件没有在屏幕上输出。我的所有print()语句也一样,控制台上什么都没有显示。
这是我的views.py:
from django.forms.models import BaseModelForm
from django.shortcuts import render, redirect
from django.http import HttpResponse, HttpResponseRedirect
from django.views import View
from django.contrib import messages
from django.urls import reverse_lazy
from .forms import EntryForm
from .models import Entry
from django.views.generic.edit import UpdateView, DeletionMixin
from django.views.generic import DeleteView
# Create your views here.
class EntryView(View):
def get(self, request):
entries = Entry.objects.all().order_by("entered_date")
form = EntryForm()
return render(request, "entries.html", {"form":form, "entries":entries})
def post(self, request):
form = EntryForm(request.POST, request.FILES) #must add request.FILES for uploads
print(request.FILES)
if form.is_valid():
form.save()
messages.success(request, "Entry created!")
return redirect("/")
else:
messages.error(request, "Please correct the errors below.")
return render(request, "entries.html", {"form":form})
class SingleEntryView(UpdateView):
template_name = "single_entry.html"
model = Entry
fields = ['ticker', 'strategy', 'result', 'comments', 'image']
success_url = '/'
form = EntryForm
def post(self, request, *args, **kwargs):
if 'delete_button' in self.request.POST:
self.object = self.get_object()
self.object.delete()
messages.success(request, "Entry has been deleted")
return HttpResponseRedirect(self.get_success_url())
elif 'update_button' in self.request.POST:
return super().post(request, *args, **kwargs)
return redirect('/')
def form_valid(self, form):
form.instance.user = self.request.user
return super().form_valid(form)
这是urls.py:
from django.urls import path
from django.contrib import admin
from . import views
urlpatterns = [
path("", views.EntryView.as_view(), name="index"),
path("entries/<int:pk>/", views.SingleEntryView.as_view(), name="single-entry"),
path("admin/", admin.site.urls)
]
这是single_entry.html:
{% extends 'base.html' %}
{% if messages %}
<ul class="messages">
{% for message in messages %}
<li{% if message.tags %} class="{{ message.tags }}"{% endif %}>{{ message }}</li>
{% endfor %}
</ul>
{% endif %}
{% block title %}
Trading Journal - Entry
{% endblock title %}Trading Journal
{% block content %}
<form method="POST" action="">
{% csrf_token %}
{% for field in form %}
{{field.label_tag}}
{{field}}
{% if field.errors %}
<small class="error">{{ field.errors|striptags }}</small>
{% endif %}
{% endfor %}
<button type="submit" name="update_button">Save</button>
<button tyupe="submit" name="delete_button">Delete</button>
</form>
<!-- {% if entry.image.url != Null %} -->
<img src="{{ entry.image.url }}" alt="{{ entry.result }}">
<!-- {% else %} -->
<img src="", alt="{{ entry.result }}">
<!-- {% endif %} -->
{% endblock content %}
Models.py:
from django.db import models
from django.core.validators import MinValueValidator, MaxValueValidator
from django.urls import reverse
from django.utils.text import slugify
class Entry(models.Model):
ONEORB="1-Min ORB"
FIVEORB="5-Min ORB"
ABCD="ABCD"
REVERSAL="Reversal"
PROFIT="Profit"
LOSS="Loss"
RESULT_CHOICES = (
(PROFIT, "Profit"),
(LOSS, "Loss")
)
STRATEGY_CHOICES = (
(ONEORB,"1-Min ORB"),
(FIVEORB,"5-Min ORB"),
(ABCD,"ABCD"),
(REVERSAL,"Reversal")
)
entered_date=models.DateField(auto_now_add=True)
ticker=models.CharField(max_length=8, default="")
strategy=models.CharField(max_length=12, choices=STRATEGY_CHOICES, default="ONEORB")
result=models.CharField(max_length=6, choices=RESULT_CHOICES, default="PROFIT")
comments=models.TextField(max_length=300, blank=True)
image = models.ImageField(upload_to="", null=True, blank=True) #will save to default BASE_DIR which is 'uploads'
def __str__(self):
return f"{self.result} {self.entered_date}"
Forms.py:
from django import forms
from .models import Entry
class EntryForm(forms.ModelForm):
class Meta:
model=Entry
fields='__all__'
我本来期待UpdateView能够用新的信息来更新条目信息。
1 个回答
0
你正在使用一个 UpdateView
,但实际上却在执行 self.object.delete()
。这听起来是不是有点奇怪?
更新操作应该在 UpdateView
中处理,而删除操作则应该在 DeleteView
中处理。然后可以使用 HTML5 的 <button formaction />
来实现。
views.py
from django.views.generic.edit import UpdateView, DeleteView
from django.contrib.messages.views import SuccessMessageMixin
from django.urls import reverse_lazy
# •••Rest of your views•••
class SingleEntryView(UpdateView, SuccessMessageMixin):
template_name = "single_entry.html"
form = EntryForm
fields = ['ticker', 'strategy', 'result', 'comments', 'image']
model = Entry
success_url = reverse_lazy("index")
success_message = "Entry has been updated"
class DeleteEntry(DeleteView, SuccessMessageMixin):
model = Entry
success_url = reverse_lazy("index")
success_message = "Entry has been deleted"
urls.py
urlpatterns = [
# •••Rest of your paths•••
path("entry/delete/<int:pk>/", views.DeleteEntry.as_view(), name="delete-entry")
# •••Rest of your paths•••
]
single_entry.html
<form method="POST" action="{% url 'single-entry' entry.pk %}">
<!--•••Rest of your form•••-->
<button type="submit" formaction="{% url 'delete-entry' entry.pk %}">Delete</button>
</form>